Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX Multichain: Updated account picker in new send flow #21576

Merged
merged 4 commits into from
Nov 1, 2023
Merged

UX Multichain: Updated account picker in new send flow #21576

merged 4 commits into from
Nov 1, 2023

Conversation

NidhiKJha
Copy link
Member

This PR is to update the account picker in Send Flow

Fixes: #1581

Manual testing steps

  1. Go to Send Flow in Multichain Flow
  2. Check the account picker matches the figma

Screenshots/Recordings

Before

Screenshot 2023-10-27 at 2 43 15 PM

After

Screenshot 2023-10-27 at 2 42 10 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha added team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead needs-ux-ds-review labels Oct 27, 2023
@NidhiKJha NidhiKJha requested a review from a team as a code owner October 27, 2023 09:13
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 27, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [58a0caa]
Page Load Metrics (1006 ± 362 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint821079273
domContentLoaded6710485105
load7917751006753362
domInteractive6710485105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 49 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74a7ab5) 68.80% compared to head (58a0caa) 68.80%.
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #21576   +/-   ##
========================================
  Coverage    68.80%   68.80%           
========================================
  Files         1037     1037           
  Lines        41285    41285           
  Branches     11020    11020           
========================================
  Hits         28403    28403           
  Misses       12882    12882
Files Coverage Δ
...ultichain/pages/send/components/account-picker.tsx 66.67% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NidhiKJha NidhiKJha merged commit b9184af into develop Nov 1, 2023
9 checks passed
@NidhiKJha NidhiKJha deleted the fix-planning-1581 branch November 1, 2023 16:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
@metamaskbot metamaskbot added the release-11.6.0 Issue or pull request that will be included in release 11.6.0 label Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vthomas13 vthomas13 vthomas13 approved these changes

@darkwing darkwing darkwing approved these changes

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.6.0 Issue or pull request that will be included in release 11.6.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NidhiKJha @metamaskbot @darkwing @vthomas13